TimeAndWeather: Reduce night 2 hours#2391
Merged
Merged
Conversation
To de-hardcode the start/stop times of effects in the script. Also export them so learners can change them.
Otherwise it is unreadable under some weather conditions. Check the museum for example.
Full night is now 6 hours, 2 hours less than before. Adjust start/stop effects: fog and lights are reduced by 2 hours. While clouds shadows is reduced by 1 hour, because the fade out looks better when is getting dark.
Collaborator
Author
|
After: |
Collaborator
Author
|
@PlayMatters would you like to check if this is short enough by using the playable link and going to Fray's End? |
|
Play this branch at https://play.threadbare.game/branches/endlessm/shorter-night/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
wjt
approved these changes
Jun 17, 2026
wjt
left a comment
wjt
left a comment
Member
There was a problem hiding this comment.
6 in-game hours at the default time scale (1 in-game day = 10 real-world minutes) is 2.5 minutes of night, compared to 8 in-game hours = 3.3 minutes of night.
I tried this and it seems good to me!
Comment on lines
+45
to
+54
| @export_group("Effects Schedule") | ||
|
|
||
| ## When does the lights on/off effect happens. | ||
| @export var lights_schedule: EffectSchedule = preload("uid://cb514qccge0gq") | ||
|
|
||
| ## When does the cloud shadows effect happens. | ||
| @export var clouds_shadows_schedule: EffectSchedule = preload("uid://jytd1cp6ogb3") | ||
|
|
||
| ## When does the fog effect happens. | ||
| @export var fog_schedule: EffectSchedule = preload("uid://bcoehk7j53s33") |
Comment on lines
+109
to
111
| debug_canvas_layer.process_mode = ( | ||
| Node.PROCESS_MODE_INHERIT if show_debug_label else Node.PROCESS_MODE_DISABLED | ||
| ) |
Member
There was a problem hiding this comment.
Another way to spell this would be:
Suggested change
| debug_canvas_layer.process_mode = ( | |
| Node.PROCESS_MODE_INHERIT if show_debug_label else Node.PROCESS_MODE_DISABLED | |
| ) | |
| debug_canvas_layer.set_process(show_debug_label) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full night is now 6 hours, 2 hours less than before.
Adjust start/stop effects: fog and lights are reduced by 2 hours. While clouds
shadows is reduced by 1 hour, because the fade out looks better when is getting
dark.
TimeAndWeather: Use panel and same font as signs for debug label
Otherwise it is unreadable under some weather conditions. Check the museum for
example.
Add effect schedule resource
To de-hardcode the start/stop times of effects in the script. Also export them
so learners can change them.
Resolves #2355